perf(over window): shortcut implementation for first_value
and last_value
in over window
#19233
+68
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously we reuse batch aggregator for
first_value
andlast_value
in OverWindow, and this required an O(n) iteration through the "current window" when evaluating output for each row. This PR introduces shortcut implementations fro these two special aggregate types to avoid the need of O(n) iteration.This also benefits
lag
andlead
because they are implemented withfirst_value
andlast_value
under the hood.A rough benchmark with a dumb query based on nexmark source showed a 392% source throughput increase introduced by this PR, during the first 10 minutes after streaming job creation.
Query:
Before:
After:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.